Fix CMake minimum required version #69
Conversation
The "C++17" value of the `CXX_STANDARD` target property, which was introduced in bitcoin-core#25, is available in CMake 3.8 and newer.
| @@ -2,7 +2,7 @@ | |||
| # Distributed under the MIT software license, see the accompanying | |||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | |||
|
|
|||
| cmake_minimum_required(VERSION 3.0) | |||
| cmake_minimum_required(VERSION 3.8) | |||
There was a problem hiding this comment.
Considering https://repology.org/project/cmake/versions, maybe 3.10 is also justified?
There was a problem hiding this comment.
Considering https://repology.org/project/cmake/versions, maybe 3.10 is also justified?
I'm not actually sure what specifically here requires 3.10, but would welcome any followup PR that changes the minimum version or adds a comment explaining the current minimum.
There was a problem hiding this comment.
I'm not actually sure what specifically here requires 3.10
Nothing requires 3.10. Just thinking about availability of CMake 3.8 and 3.9 on real systems.
| @@ -2,7 +2,7 @@ | |||
| # Distributed under the MIT software license, see the accompanying | |||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | |||
|
|
|||
| cmake_minimum_required(VERSION 3.0) | |||
| cmake_minimum_required(VERSION 3.8) | |||
There was a problem hiding this comment.
Considering https://repology.org/project/cmake/versions, maybe 3.10 is also justified?
I'm not actually sure what specifically here requires 3.10, but would welcome any followup PR that changes the minimum version or adds a comment explaining the current minimum.
The "C++17" value of the
CXX_STANDARDtarget property, which was introduced in #25, is available in CMake 3.8 and newer.Tested with old CMake versions available here.